update max SciPy to 1.7.0

[esc]

As title

[esc]

My guess is that the CI config doesn't activate, because the changes need to be on master?

[stuartarchibald]

Thanks for the patch, will the conda recipes also need updating?

numba-scipy/buildscripts/conda_recipes/numba-scipy/meta.yaml

Lines 21 to 30 in 9764341

	- scipy<=1.6.2
	- setuptools
	run:
	- python
	- numba
	- scipy<=1.6.2
	test:
	requires:
	- scipy<=1.6.2

[esc]

Thanks for the patch, will the conda recipes also need updating?

numba-scipy/buildscripts/conda_recipes/numba-scipy/meta.yaml

Lines 21 to 30 in 9764341

	- scipy<=1.6.2
	- setuptools
	run:
	- python
	- numba
	- scipy<=1.6.2
	test:
	requires:
	- scipy<=1.6.2

fixed in ed96485

[esc]

Fixes #66

[de846]

Thanks for this PR 👍 Is it possible to get this merged anytime soon?

[stuartarchibald]

Think line 66 also needs the same change?

[esc]

fixed in e671fbb

[esc]

@stuartarchibald I believe I have addressed everything in this pull-request. Let's get this merged and make a new PR if broken?

[esc]

@de846 thank you for the ping on this issue.

[stuartarchibald]

Thanks for the patch and fixes.

[esc]

@stuartarchibald thank you for approval, will merge now and see what happens.

[esc]

So, after merging this, it seems like SciPy 1.7.0 isn't being picked up at all. Neither during build nor during test:

During build I see:

Run conda install -c numba conda-build python=3.8 numba>=0.45 'scipy>=1.4,<=1.7.0' flake8 pytest pip
Obtaining file:///home/runner/work/numba-scipy/numba-scipy
Installing collected packages: numba-scipy
  Running setup.py develop for numba-scipy
Successfully installed numba-scipy

But this doesn't actually matter, because we do build with conda-build eventually.

There we get:

Run conda build -c defaults -c numba --python 3.8 buildscripts/conda_recipes/numba-scipy/
...
    scipy:            1.6.2-py38had2a1c9_1     

Then during one of the test runs, I get:

Run conda install -c numba python=3.8 numba>=0.45 'scipy>=1.4,<=1.7.0' flake8 pytest
...
  scipy                     1.6.2            py38had2a1c9_1  

Probably it would make sense if someone else could confirm what I am seeing, to make sure I am not looking at the wrong output.

[stuartarchibald]

@esc is there a scipy 1.7.0 build in defaults?

[esc]

@esc is there a scipy 1.7.0 build in defaults?

Anaconda.org does seem to imply this exists:

https://anaconda.org/anaconda/scipy

[esc]

I see, it's an off by one error, we should have used 1.7.1 not 1.7.0 apparently. I just tried making that change locally on my Mac and that got me the correct version.

[esc]

I see, it's an off by one error, we should have used 1.7.1 not 1.7.0 apparently. I just tried making that change locally on my Mac and that got me the correct version.

Correct version yes, but I was unable to complete the package build:

Traceback (most recent call last):
  File "/Users/vhaenel/miniconda3/bin/conda-build", line 11, in <module>
    sys.exit(main())
  File "/Users/vhaenel/miniconda3/lib/python3.7/site-packages/conda_build/cli/main_build.py", line 474, in main
    execute(sys.argv[1:])
  File "/Users/vhaenel/miniconda3/lib/python3.7/site-packages/conda_build/cli/main_build.py", line 465, in execute
    verify=args.verify, variants=args.variants)
  File "/Users/vhaenel/miniconda3/lib/python3.7/site-packages/conda_build/api.py", line 195, in build
    variants=variants
  File "/Users/vhaenel/miniconda3/lib/python3.7/site-packages/conda_build/build.py", line 3013, in build_tree
    notest=notest,
  File "/Users/vhaenel/miniconda3/lib/python3.7/site-packages/conda_build/build.py", line 2291, in build
    newly_built_packages = bundlers[pkg_type](output_d, m, env, stats)
  File "/Users/vhaenel/miniconda3/lib/python3.7/site-packages/conda_build/build.py", line 1565, in bundle_conda
    "run that executable.".format(dep, env_var_name))
conda_build.exceptions.CondaBuildException: Empty package; python present in build and host deps.  You probably picked up the build environment's python  executable.  You need to alter your recipe to  use the PYTHON env var in your recipe to run that executable.

[esc]

A fix is here: #71