Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: init container logs #2245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: init container logs #2245

wants to merge 1 commit into from
+9 −1

Conversation

veds-g
Copy link
Contributor

@veds-g veds-g commented Nov 28, 2024

Fixes #2234

@veds-g
init container logs
0373bb1 
Signed-off-by: veds-g <[email protected]>
@KeranYang
Copy link
Member

LGTM, make sure this is properly tested before merging. Thanks!

@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.01%. Comparing base (f5a79bf) to head (0373bb1).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2245      +/-   ##
==========================================
- Coverage   64.14%   64.01%   -0.13%     
==========================================
  Files         339      339              
  Lines       41035    41035              
==========================================
- Hits        26322    26269      -53     
- Misses      13639    13697      +58     
+ Partials     1074     1069       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeranYang KeranYang KeranYang approved these changes

@whynowy whynowy whynowy approved these changes

@vigith vigith vigith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display init container logs
4 participants
@veds-g @KeranYang @vigith @whynowy