feat: Built-in Pulsar source #2237
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2237 +/- ##
==========================================
+ Coverage 63.91% 64.19% +0.27%
==========================================
Files 338 342 +4
Lines 41085 41174 +89
==========================================
+ Hits 26259 26431 +172
+ Misses 13756 13670 -86
- Partials 1070 1073 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
vigith
reviewed
Nov 25, 2024
rust/numaflow-core/src/message.rs
Outdated
Comment on lines
123
to
143
| impl TryFrom<PulsarMessage> for Message { | ||
| type Error = Error; | ||
|
|
||
| fn try_from(message: PulsarMessage) -> Result<Self> { | ||
| let offset = Offset::Int(IntOffset::new(message.offset, 1)); // FIXME: partition id | ||
|
|
||
| Ok(Message { | ||
| keys: vec![message.key], | ||
| value: message.payload, | ||
| offset: Some(offset.clone()), | ||
| event_time: message.event_time, | ||
| id: MessageID { | ||
| vertex_name: get_vertex_name().to_string(), | ||
| offset: offset.to_string(), | ||
| index: 0, | ||
| }, | ||
| headers: message.headers, | ||
| }) | ||
| } | ||
| } | ||
|
|
vigith
reviewed
Nov 25, 2024
Comment on lines
19
to
25
| type PulsarSource struct { | ||
| ServerAddr string `json:"serverAddr" protobuf:"bytes,1,name=server_addr"` | ||
| Topic string `json:"topic" protobuf:"bytes,2,name=topic"` | ||
| ConsumerName string `json:"consumerName" protobuf:"bytes,3,name=consumerName"` | ||
| SubscriptionName string `json:"subscriptionName" protobuf:"bytes,4,name=subscriptionName"` | ||
| MaxUnack uint32 `json:"maxUnack,omitempty" protobuf:"bytes,5,opt,name=maxUnack"` | ||
| } |
There was a problem hiding this comment.
please add TLS and Auth too, if you prefer you can do that in a follow up PR.
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Tested by running a Pipeline and a Monovertex with Pulsar as built-in source