Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make sidecar container change backward compatible #2236

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Nov 22, 2024

#2230

Tested in k8s < 1.29, it worked.

@whynowy whynowy requested a review from vigith as a code owner November 22, 2024 07:58
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 45.65217% with 25 lines in your changes missing coverage. Please review.

Project coverage is 63.90%. Comparing base (c5afc90) to head (d6addec).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/cmd/start.go 0.00% 8 Missing ⚠️
pkg/apis/numaflow/v1alpha1/side_inputs.go 71.42% 3 Missing and 1 partial ⚠️
pkg/apis/numaflow/v1alpha1/container_builder.go 25.00% 2 Missing and 1 partial ⚠️
pkg/apis/numaflow/v1alpha1/mono_vertex_types.go 50.00% 2 Missing and 1 partial ⚠️
pkg/apis/numaflow/v1alpha1/vertex_types.go 40.00% 2 Missing and 1 partial ⚠️
pkg/apis/numaflow/v1alpha1/deprecated.go 71.42% 2 Missing ⚠️
pkg/reconciler/isbsvc/controller.go 0.00% 1 Missing ⚠️
pkg/reconciler/pipeline/controller.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2236      +/-   ##
==========================================
- Coverage   63.91%   63.90%   -0.01%     
==========================================
  Files         338      339       +1     
  Lines       41085    41118      +33     
==========================================
+ Hits        26259    26276      +17     
- Misses      13756    13769      +13     
- Partials     1070     1073       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@whynowy whynowy merged commit ae05a7c into numaproj:main Nov 22, 2024
25 checks passed
@whynowy whynowy deleted the ffu branch November 22, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants