-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworks SSH Tunneling For SQL Databases #2708
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
nickzelei
force-pushed
the
nick/tunnel-rework
branch
from
October 1, 2024 20:55
e12054f
to
ad60fbc
Compare
nickzelei
force-pushed
the
nick/tunnel-rework
branch
from
October 3, 2024 23:19
fef6647
to
aa5bd97
Compare
nickzelei
changed the title
Reworks SSH Tunneling
Reworks SSH Tunneling For SQL Databases
Oct 3, 2024
alishakawaguchi
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks SSH Tunneling for SQL Databases.
We previously were starting a TCP server and proxying the network connections between it by exposing a host port and giving that to the database drivers.
We are no longer doing that in favor of creating driver-specific database connectors that now are providing with a custom
DialFunc
which, upon invocation, first connects to the configured jump box via the SSH Client. The dial is then passed to that connection to dial the actual database.This is much cleaner because now we can just provide the database connection directly to
sql.Open
and all of the dialing complexities are handled behind the scenes by the system libs themselves. Nice!This rework allows for much better tests and error propagation. Nice Nice!