add missing import statement modules/base/module.py #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Jakob thanks for doing this. I found this in a couple of branches I have open but the fix never made it into the develop |
fschlueter
previously approved these changes
Dec 12, 2024
|
I approved it, however, what I think would be a litte bit of a better solution would be to import |
|
Hi Felix, I changed the import statement and if condition according to your suggestions. |
fschlueter
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a missing import statement in modules/base/module.py, which sometimes caused an error in line 77 of the file. With this PR the missing import statement is added.