refactor get_time_delay function in rno-g detector

[fschlueter]

This reduces code for the most common way of using the function cable_only=False use_store=True

[shallmann]

did you test that it gives consistent results? I added some comments.

[fschlueter]

did you test that it gives consistent results? I added some comments.

Nope :(

[fschlueter]

Maybe a more general question also to @cg-laser, @sjoerd-bouma and @philippwindischhofer : I do not like this implementation with the cable_only (using strings in the component name ...). Is there a use case where one is interested in only the cable/fiber delay and not the delay of the entire response chain? If that is not the case I will delete the entire option cable_only

[fschlueter]

okay I removed the function cable_only entirely. Now the function get_cable_delay calls get_time_delay and this returns the time delay of the entire chain possibly including amplifier and filter.

[philippwindischhofer]

Hey @fschlueter sorry to be slow, just catching up.

I think for most (non-expert) use-cases, we don't need to look separately at the cable delay. The (relative) delay between two separate signal chains is what is most important, I think.

[fschlueter]

@shallmann do you want to approve?

[shallmann]

on it... just looking at the changes once more now

[shallmann]

Please check if the print in the main is intended. Otherwise good to go.

[shallmann]

The optional argument now no longer exists, no?

[shallmann]

Thanks for cleaning up!