Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STUN: fix monitoring with RTCP flows #2603

Merged
merged 1 commit into from
Oct 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lib/protocols/stun.c
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,10 @@ static int stun_search_again(struct ndpi_detection_module_struct *ndpi_struct,
flow->detected_protocol_stack[1] == NDPI_PROTOCOL_UNKNOWN) {
/* From RTP dissector; if we have RTP and RTCP multiplexed together (but not STUN, yet) we always
use RTP, as we do in RTP dissector */
ndpi_set_detected_protocol(ndpi_struct, flow, NDPI_PROTOCOL_UNKNOWN, NDPI_PROTOCOL_RTP, NDPI_CONFIDENCE_DPI);
if(!flow->monitoring)
ndpi_set_detected_protocol(ndpi_struct, flow, NDPI_PROTOCOL_UNKNOWN, NDPI_PROTOCOL_RTP, NDPI_CONFIDENCE_DPI);
else
NDPI_LOG_DBG(ndpi_struct, "Skip RTP packet because in monitoring\n");
}
} else if(rtp_rtcp == IS_RTCP) {
NDPI_LOG_DBG(ndpi_struct, "RTCP\n");
Expand Down
Loading