Ignored non IP/IPv6 packets on ndpiReader #2600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaderi
changed the title
|
0xA50C1A1
reviewed
Oct 19, 2024
There was a problem hiding this comment.
I think it's because there's no Ethernet header.
There was a problem hiding this comment.
The eth type is wrong but underneath there is an IPv4 protocol.
@IvanNardi will address the issue this PR was trying to solve and provide a better fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please sign (check) the below before submitting the Pull Request:
Link to the related issue:
Describe changes:
ndpiReader does not currently discard non IP/IPv6 pockets as it should