You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The endianess issue is unrelated to these changes (see #2260)
Since I don't have time to look into that (see #1828 for tracking the issue), I remove the new trace: it is kind of cheating, but I don't want to have failures on the CI...
* fix header length check: we must take into account optional extension
header
* it seems the check on UTPv1 header is weak only in the DATA case: wait
for multiple packets only in that case
The endianess issue is unrelated to these changes (see #2260) Since I don't have time to look into that (see #1828 for tracking the issue), I remove the new trace: it is kind of cheating, but I don't want to have failures on the CI...
Btw, what was the problem? I've got a s390x Alpine Linux VM, so I guess I can tinker with this stuff at my leisure.
The endianess issue is unrelated to these changes (see #2260) Since I don't have time to look into that (see #1828 for tracking the issue), I remove the new trace: it is kind of cheating, but I don't want to have failures on the CI...
Btw, what was the problem? I've got a s390x Alpine Linux VM, so I guess I can tinker with this stuff at my leisure.
The pcap attached in #2260 returns different results only on s390x CI test
The endianess issue is unrelated to these changes (see #2260) Since I don't have time to look into that (see #1828 for tracking the issue), I remove the new trace: it is kind of cheating, but I don't want to have failures on the CI...
Btw, what was the problem? I've got a s390x Alpine Linux VM, so I guess I can tinker with this stuff at my leisure.
The pcap attached in #2260 returns different results only on s390x CI test
Ok, I'll create a PR when I figure out what's wrong.
The endianess issue is unrelated to these changes (see #2260) Since I don't have time to look into that (see #1828 for tracking the issue), I remove the new trace: it is kind of cheating, but I don't want to have failures on the CI...
Btw, what was the problem? I've got a s390x Alpine Linux VM, so I guess I can tinker with this stuff at my leisure.
The pcap attached in #2260 returns different results only on s390x CI test
Ok, I'll create a PR when I figure out what's wrong.
I have seen similar issues for years so I don't think that the issue is the newer code....
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IvanNardi
commented
IvanNardi
force-pushed
the
bittorrent-utpv1
branch
from
