Fixes buffer overflow when parsing invalid TCP options

ntop · Oct 17, 2024 · 6a744d0 · 6a744d0
1 parent 1c4ae43
commit 6a744d0
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/lib/ndpi_main.c b/src/lib/ndpi_main.c
@@ -6967,7 +6967,7 @@ static int ndpi_init_packet(struct ndpi_detection_module_struct *ndpi_str,
 		int j = i+2;
 		u_int8_t opt_len = len - 2;
 
-		while(opt_len > 0) {
+		while((opt_len > 0) && (j < options_len)) {
 		  rc = snprintf(&options_fp[options_fp_idx], sizeof(options_fp)-options_fp_idx, "%02x", options[j]);
 		  options_fp_idx += rc;
 		  j++, opt_len--;