Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: variable length data output from Wasm runtime #3

Draft
wants to merge 4 commits into
base: import-data
Choose a base branch
from

Conversation

jdvlio
Copy link
Contributor

@jdvlio jdvlio commented Jan 31, 2022

Use an appropriately sized buffer in a linear memory instance to permit the export of arbitrary data from the wasm runtime.

- [ ] Refactor in order to accomodate the FFI boundary

  • Repurpose the old tests to go with the newly modified exec-wasm-with-data function
  • Error handling
  • Accomodate the export of start functions
  • Fix all those pesky compiler errors

A new struct `Proc` is defined for output purposes.  Due to crossing an
FFI boundary this will have to change.
wasmi-impl/src/lib.rs Outdated Show resolved Hide resolved
wasmi-impl/src/lib.rs Outdated Show resolved Hide resolved
@PiDelport PiDelport marked this pull request as draft January 31, 2022 12:44
wasmi-impl/src/lib.rs Outdated Show resolved Hide resolved
@jdvlio jdvlio changed the title [WIP] Variable length data output from Wasm runtime [WIP] feat: variable length data output from Wasm runtime Feb 1, 2022
The `wasmi` library provides functionality for rounding up units of
memory and this is now properly utilised.  Error handling for this
calculation has now also been implemented.
@jdvlio jdvlio requested review from billguo99 and PiDelport February 2, 2022 06:15
Copy link

@PiDelport PiDelport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general comment, we may want to look at returning this buffer in a way similar to what's described here?

#4 (review)

@Brianspha Brianspha requested review from Brianspha and removed request for Brianspha May 6, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants