Skip to content
This repository has been archived by the owner on May 9, 2022. It is now read-only.

Add local attestation support #60

Merged
merged 31 commits into from
May 29, 2021
Merged

Add local attestation support #60

merged 31 commits into from
May 29, 2021

Conversation

longtomjr
Copy link
Collaborator

@longtomjr longtomjr commented May 14, 2021 •
edited
Loading

Closes: #34

@longtomjr longtomjr changed the base branch from he-uenclave-refactor to main May 18, 2021 18:16
@longtomjr longtomjr marked this pull request as ready for review May 18, 2021 18:17
@longtomjr longtomjr changed the title WIP: Local attestation impl Add local attestation support May 18, 2021
@longtomjr longtomjr force-pushed the he-local-attestation branch from 9b8dfcc to b1bc710 Compare May 18, 2021 18:19
@longtomjr longtomjr self-assigned this May 18, 2021
@longtomjr longtomjr added M: auth enclave Module: Authorisation enclave (rtc_auth_enclave) M: data enclave Module: Data enclave (rtc_data_enclave) feat New feature or request labels May 18, 2021
@PiDelport PiDelport force-pushed the he-local-attestation branch from b1bc710 to 589a029 Compare May 20, 2021 19:20
@PiDelport
Copy link
Collaborator

I rebased and resolved the conflicts, so long: I'll tackle the review next.

@longtomjr longtomjr force-pushed the he-local-attestation branch from 589a029 to 999d4e0 Compare May 25, 2021 13:29
PiDelport
PiDelport reviewed May 26, 2021
View reviewed changes
Copy link
Collaborator

@PiDelport PiDelport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hefty review, but done! 🎉

rtc_uenclave/auth-sys/build.rs Outdated Show resolved Hide resolved
rtc_uenclave/data-sys/build.rs Outdated Show resolved Hide resolved
rtc_tenclave/Cargo.lock Outdated Show resolved Hide resolved
rtc_tenclave/Cargo.toml Show resolved Hide resolved
rtc_uenclave/data-sys/build.rs Outdated Show resolved Hide resolved
rtc_tenclave/src/dh/sessions.rs Show resolved Hide resolved
rtc_udh/src/lib.rs Show resolved Hide resolved
rtc_tenclave/src/dh/sessions.rs Outdated Show resolved Hide resolved
rtc_tenclave/src/dh/sessions.rs Outdated Show resolved Hide resolved
rtc_types/src/dh.rs Show resolved Hide resolved
@longtomjr longtomjr mentioned this pull request May 26, 2021
Open
@PiDelport PiDelport force-pushed the he-local-attestation branch from 999d4e0 to 92952de Compare May 27, 2021 12:48
@PiDelport
Copy link
Collaborator

Rebased and updated for #80:

This simplifies the Cargo.lock diffs for this branch. 🎉

longtomjr
longtomjr commented May 28, 2021
View reviewed changes
Copy link
Collaborator Author

@longtomjr longtomjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good! Thanks

@PiDelport PiDelport force-pushed the he-local-attestation branch from 652d2a7 to 5f1cb5e Compare May 28, 2021 12:48
@PiDelport PiDelport force-pushed the he-local-attestation branch from 1985ee9 to 5f1cb5e Compare May 28, 2021 13:03
longtomjr and others added 20 commits May 28, 2021 16:21
@longtomjr @PiDelport
refactor(dh): prefix enclave functions from edl
322793f
@longtomjr @PiDelport
feat(dh): add to uenclave and basic integration test
18af0c9
@longtomjr @PiDelport
cleanup(dh): remove debug printlines
ea71a55
@longtomjr @PiDelport
feat(dh): fix uenclave tests
3074594
@longtomjr @PiDelport
test(dh): fix tenclave unit tests by ignoring the dh mod
acf43b9
@longtomjr @PiDelport
feat(dh): support testing and cleanup module structure
f83f666
@PiDelport
deps(rtc_tenclave): specify sgx_1.1.3 tag for once_cell-sgx
d23df5c 
This will avoid pulling in post-sgx_1.1.3 revisions unexpectedly.
@PiDelport
docs(HACKING): add section: Aligned memory allocation for secret values
1a90824
@PiDelport
docs(auth-sys,data-sys): remove resolved TODO
d6619da
@PiDelport
refactor(rtc_udh): get_responder: take enclave id by value, not refer…
6e0f8be 
…ence

This is more consistent with the surrounding code.
@PiDelport
test(rtc_tenclave): use sgx_enclave_id_t return type for stub
0d2bfde
@PiDelport
refactor(rtc_udh): use "enclave_id: sgx_enclave_id_t" parameter conve…
d62f352 
…ntion
@PiDelport
refactor(rtc_tenclave,dh): use sgx_enclave_id_t type for DhResponders…
8b3d486 
… map
@PiDelport
refactor(rtc_tenclave,dh): use "enclave_id: sgx_enclave_id_t" paramet…
9c2d49b 
…er convention
@PiDelport
refactor(rtc_tenclave,dh): default to passing sgx_enclave_id_t by value
d050e11
@PiDelport
chore(rtc_udh): remove stray test code
9cefdbb
@PiDelport
chore(rtc_tenclave): remove commented code
8de36cf
@PiDelport
chore(rtc_tenclave,dh): remove commented code
b348f81
@PiDelport
docs: add & update rustdoc comments
035359d
@PiDelport
build(rtc_auth_enclave,rtc_data_enclave): factor out ENCLAVE_NAME
5b6f3d5
@PiDelport PiDelport force-pushed the he-local-attestation branch from 41e6643 to 5b6f3d5 Compare May 28, 2021 14:21
@PiDelport
refactor(rtc_tenclave,protected_channel): factor out DeterministicAes…
2741ebe 
…GcmIvConstructor

Also add additional documentation and context around the IV
construction.
@longtomjr longtomjr merged commit b396fb1 into main May 29, 2021
@longtomjr longtomjr deleted the he-local-attestation branch May 29, 2021 09:59
@longtomjr longtomjr restored the he-local-attestation branch May 29, 2021 09:59
@PiDelport PiDelport mentioned this pull request May 31, 2021
Merged
PiDelport
PiDelport reviewed May 31, 2021
View reviewed changes
Copy link
Collaborator

@PiDelport PiDelport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to push the remaining changes before this got merged, but missed the window, sorry! I pushed a quick follow-up PR: #85

@PiDelport PiDelport mentioned this pull request May 31, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PiDelport PiDelport PiDelport left review comments

@Nghondzweni Nghondzweni Awaiting requested review from Nghondzweni

Assignees

@longtomjr longtomjr

Labels
feat New feature or request M: auth enclave Module: Authorisation enclave (rtc_auth_enclave) M: data enclave Module: Data enclave (rtc_data_enclave)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup local mutual attestation between the data-enclave and the authorization-enclave
2 participants
@longtomjr @PiDelport