Skip to content
This repository has been archived by the owner on May 9, 2022. It is now read-only.

Add remote attestation support for the Authorization Enclave #55

Merged
merged 1 commit into from
May 18, 2021

Conversation

longtomjr
Copy link
Collaborator

Closes: #35

@longtomjr longtomjr added the M: auth enclave Module: Authorisation enclave (rtc_auth_enclave) label May 11, 2021
@longtomjr longtomjr self-assigned this May 11, 2021
@longtomjr longtomjr force-pushed the he-auth-attestation branch from cca5e46 to fa50cfd Compare May 13, 2021 09:55
@PiDelport PiDelport added the feat New feature or request label May 18, 2021
Copy link
Collaborator

@PiDelport PiDelport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @Nghondzweni and I gave this a walk-through, and the only thing I spotted was that PR #58's fix for the data enclave Makefile's Crate_Files declaration also needs to be applied for the auth enclave, now that it also depends on rtc_tenclave, but we can do that as a follow-up PR.

Update 1: Oh, wait, there was also an unexpected Cargo lockfile change. Let me investigate that quick…'

Update 2: Okay, the issue was an unexpected sgx_tcrypto version bump in the data enclave's lock file, because rtc_tenclave is pulling sgx_tcrypto without the patch from the old to new teaclave repositories. We should probably standardise these repository references across the enclaves, but that's a bit of a rabbithole at this point.

@longtomjr
Copy link
Collaborator Author

longtomjr commented May 18, 2021

Looks good! @Nghondzweni and I gave this a walk-through, and the only thing I spotted was that PR #58's fix for the data enclave Makefile's Crate_Files declaration also needs to be applied for the auth enclave, now that it also depends on rtc_tenclave, but we can do that as a follow-up PR.

Lets do that in a follow up, and get this merged in. (#62)

Update 1: Oh, wait, there was also an unexpected Cargo lockfile change. Let me investigate that quick…'

Update 2: Okay, the issue was an unexpected sgx_tcrypto version bump in the data enclave's lock file, because rtc_tenclave is pulling sgx_tcrypto without the patch from the old to new teaclave repositories. We should probably standardise these repository references across the enclaves, but that's a bit of a rabbithole at this point.

I am currently considering a separate workspace for enclave, and non-enclave code, but I am not sure yet what the implications are for that. Will add a task to investigate. (#63)

@longtomjr longtomjr merged commit 1aca127 into main May 18, 2021
@PiDelport
Copy link
Collaborator

I have a fix for #62 ready: I'll PR that shortly.

Consolidating the enclave code under a single workspace sounds like a great idea, if we can get that working!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat New feature or request M: auth enclave Module: Authorisation enclave (rtc_auth_enclave)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add remote attestation support for the Authorization Enclave
3 participants