Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds 3 mvp enclave functions #5

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

adds 3 mvp enclave functions #5

wants to merge 7 commits into from

Conversation

tshepang
Copy link
Contributor

@tshepang tshepang commented Feb 14, 2023 •
edited
Loading

@tshepang tshepang changed the base branch from main to feat-initial-user-auth-enclave February 14, 2023 00:20
@tshepang tshepang mentioned this pull request Feb 14, 2023
Closed
@tshepang tshepang changed the base branch from feat-initial-user-auth-enclave to main February 20, 2023 07:34
@tshepang tshepang changed the base branch from main to feat-initial-sealing-crate February 20, 2023 08:23
@tshepang tshepang changed the base branch from feat-initial-sealing-crate to main February 20, 2023 08:24
@tshepang tshepang force-pushed the utils branch 2 times, most recently from 2d91e80 to 074b21c Compare February 20, 2023 09:16
@tshepang tshepang requested review from jdvlio and sonasi February 20, 2023 09:18
@tshepang tshepang mentioned this pull request Feb 20, 2023
Closed
@tshepang tshepang force-pushed the utils branch 4 times, most recently from a8e15a0 to 5531cf7 Compare February 28, 2023 13:16
@billguo99
Copy link

Can you link the ClickUp Task to the PR please?

billguo99
billguo99 reviewed Mar 6, 2023
View reviewed changes
utils/README.md Outdated Show resolved Hide resolved
utils/README.md Outdated Show resolved Hide resolved
utils/README.md Outdated Show resolved Hide resolved
@billguo99
Copy link

So how do we plan on calling these util functions through the gRPC server in production?

@tshepang
Copy link
Contributor Author

tshepang commented Mar 8, 2023

There are examples of Python calls in README.md, in test section.
As for calling them in production, @jdvlio can you advice?

@tshepang
Copy link
Contributor Author

tshepang commented Mar 8, 2023

@billguo99 I linked the clickup tasks

tshepang added 3 commits March 9, 2023 11:31
@tshepang
docs: fix instructions
a255ddc
@tshepang
fix: replace a badly-named var
a1437ee 
See #5 (comment)
@tshepang
chore: remove unfinished feature
6bdadb0 
Revert "feat(transaction-sign): sign algorand transactions in enclave"

This reverts commit c4a4ad9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billguo99 billguo99 billguo99 left review comments

@jdvlio jdvlio Awaiting requested review from jdvlio

@sonasi sonasi Awaiting requested review from sonasi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tshepang @billguo99