Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pre-commit hooks for code style and commit message quality #66

Merged
merged 6 commits into from
Jul 1, 2021

Conversation

hydrosquall
Copy link
Member

@hydrosquall hydrosquall commented Jul 1, 2021

Motivation

Changes

Testing

  • I wrote several non-compliant commit messages , and was warned with information about what needed to be fixed in the message before they'd be accepted. Here's an example of how it looks when a stray capital letter finds its way in : https://a.cl.ly/eDuynZmj
    Image 2021-06-30 at 8 58 52 PM

Notes

@hydrosquall hydrosquall self-assigned this Jul 1, 2021
@hydrosquall hydrosquall added the chore Chore or quality of life improvement label Jul 1, 2021
@hydrosquall hydrosquall force-pushed the cameron.yick/commit-hooks-commit-msg-and-prettier branch from 64c35e6 to 0d38ed0 Compare July 1, 2021 01:28
Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @hydrosquall! I'll leave it for you to merge because I don't want to accidentally trigger a release.

@hydrosquall
Copy link
Member Author

@willingc thank you!

And not to worry, a release should only be triggered if we explicitly attach a Github release label to this PR (but we'll see momentarily whether this was set up correctly :).

@github-actions
Copy link

🚀 PR was released in v8.2.12 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore or quality of life improvement released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants