fix(r): new utils, deprecated msg, typo

nteetor · Mar 14, 2020 · e1ed698 · e1ed698
1 parent 8f89f6e
commit e1ed698
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/NAMESPACE b/NAMESPACE
@@ -163,6 +163,7 @@ export(width)
 import(rlang)
 importFrom(htmltools,HTML)
 importFrom(htmltools,attachDependencies)
+importFrom(htmltools,div)
 importFrom(htmltools,findDependencies)
 importFrom(htmltools,htmlDependency)
 importFrom(htmltools,resolveDependencies)

diff --git a/R/button.R b/R/button.R
@@ -288,11 +288,11 @@ updateLinkInput <- function(id, label = NULL, value = NULL,
 buttonGroupInput <- function(..., id, choices = NULL, values = choices,
                              labels = deprecated(),
                              direction = "horizontal") {
-  if (is_present(labels)) {
+  if (!is_missing(labels)) {
     deprecate_soft(
       "0.2.0",
-      "buttonGroupInput(labels = )",
-      "buttonGroupInput(choices = )"
+      "yonder::buttonGroupInput(labels = )",
+      "yonder::buttonGroupInput(choices = )"
     )
 
     choices <- labels

diff --git a/R/design-scroll.R b/R/design-scroll.R
@@ -8,7 +8,7 @@
 #'
 #' @param direction One of `"horizontal"` or `"vertical"` specifying which
 #'   direction to scroll overflowing content, defaults to `"vertical"`, in which
-#'   case the content may croll up and down.
+#'   case the content may scroll up and down.
 #'
 #' @family design utilities
 #' @export

diff --git a/R/utils.R b/R/utils.R
@@ -1,6 +1,10 @@
 # necessary for `createRenderFunction()`
 globalVariables("func")
 
+reduce <- function(x, f, init) {
+  Reduce(f, x, init)
+}
+
 drop_nulls <- function(x) {
   if (length(x) == 0) {
     x
@@ -9,11 +13,6 @@ drop_nulls <- function(x) {
   }
 }
 
-# Included until rlang exports `is_present()`
-is_present <- function(arg) {
-  !is_missing(maybe_missing(arg))
-}
-
 str_conjoin <- function(x, con = "or") {
   if (length(x) == 1) {
     return(as.character(x))

diff --git a/R/yonder.R b/R/yonder.R
@@ -1,5 +1,5 @@
 #' @importFrom htmltools HTML htmlDependency attachDependencies
-#'   suppressDependencies resolveDependencies findDependencies tags
+#'   suppressDependencies resolveDependencies findDependencies tags div
 #'   tagAppendAttributes tagAppendChildren surroundSingletons takeSingletons
 #' @importFrom shiny observe getDefaultReactiveDomain installExprFunction
 #'   createRenderFunction createWebDependency