Go 1.22 #97
Merged
Go 1.22 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop 1.21 and use 1.23 for test and build. Closes #75. Signed-off-by: Andrey Butusov <[email protected]>
Signed-off-by: Andrey Butusov <[email protected]>
End-rey
requested review from
roman-khimov,
smallhive and
tatiana-nspcc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
=========================================
+ Coverage 2.12% 2.50% +0.38%
=========================================
Files 11 11
Lines 754 757 +3
=========================================
+ Hits 16 19 +3
Misses 738 738 ☔ View full report in Codecov by Sentry. |
End-rey
force-pushed
the
75-go-122-upgrade
branch
from
f4c86ad to
dad76ef
Compare
roman-khimov
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75.
There is in
internal/generator.goin funcnextSliceuserand.Read. The error has not been handled before. What is the best thing to do now?