Feat/search load #91
Feat/search load #91
Conversation
carpawell
requested review from
roman-khimov,
smallhive and
tatiana-nspcc
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
=========================================
- Coverage 2.20% 2.11% -0.10%
=========================================
Files 11 11
Lines 725 758 +33
=========================================
Hits 16 16
- Misses 709 742 +33 ☔ View full report in Codecov by Sentry. |
carpawell
force-pushed
the
feat/search-load
branch
from
12b20d5 to
146142d
Compare
carpawell
force-pushed
the
feat/search-load
branch
from
a29103e to
0ec4cd3
Compare
|
The search time should be calculated as the total search time in the container divided by the number of objects; it should not depend on the number of objects found. |
|
@cthulhu-rider Are you interested in the scenario when you specify a json file instead of a cid? |
internal/native/client.go
Outdated
| Value string | ||
| } | ||
|
|
||
| func (c *Client) Search(cnrString string, filtersJS []filter) (int, error) { |
There was a problem hiding this comment.
lets add docs at least to know what does int return means
There was a problem hiding this comment.
this doc is not expected to be read by anyone. this code is also impossible to use by a human, only as an extension inside a virtual machine
there are some well-known extensions that are "documented" via examples: https://github.com/grafana/xk6-loki/tree/5248b47b4efdd234403ba13e6f46dc173f9a142e/examples or via a readmi file (https://github.com/grafana/xk6-loki/blob/5248b47b4efdd234403ba13e6f46dc173f9a142e/README.md)
not sure if it applies to us (#85)
There was a problem hiding this comment.
is this an autogen code? If not, any dev can read and support it. Small tip would be appreciated
There was a problem hiding this comment.
it is not a problem to me, added a comment. now we have one documented method out of 7
internal/native/client.go
Outdated
| Value string | ||
| } | ||
|
|
||
| func (c *Client) Search(cnrString string, filtersJS []filter) (int, error) { |
There was a problem hiding this comment.
why it should be? it is only a container that will be used when code is translated from JS to Go
There was a problem hiding this comment.
why method is exported then? And the fields. im lookin at this code as a regular Go one
There was a problem hiding this comment.
why method is exported then?
to make it possible to be called in k6 code
im lookin at this code as a regular Go one
idk, i think this code should be considered as a private package code, it is called by an external k6 code that is never human (and that is never written based on our neofs code) and that just looks for exported fields with appropriate names. can be exported, OK, but changes nothing
scenarios/grpc_search.js
Outdated
| import { check } from 'k6'; | ||
| import native from 'k6/x/neofs/native'; | ||
|
|
||
| const grpc_client = native.connect(__ENV.GRPC_ENDPOINT, '', 5, 15); |
There was a problem hiding this comment.
id make consts for non-obvious literals
There was a problem hiding this comment.
and empty string pls, i can only imagine what does it mean
me not, current approach looks similar to neofs-cli |
carpawell
force-pushed
the
feat/search-load
branch
2 times, most recently
from
707028f to
81c72a2
Compare
Simple operation, supports generic filters and relative metrics (seconds per single object in results). Signed-off-by: Pavel Karpy <[email protected]>
It does what it claims, however, it may be adjusted to real requirements in the future. Controlled by a number of iterations and number of virtual users. Searches for objects with `test=test` attributes. Closes #90. Run example: ``` ▶ ./xk6-neofs run -e i=200 -e vu=1 -e cid=FB6UeNbx65iHuNKNbGsb2xHxooU7kXangaUxv9P6h9uW -e GRPC_ENDPOINT=s01.neofs.devenv:8080 scenarios/grpc_search.js ``` Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
feat/search-load
branch
from
81c72a2 to
abecf3c
Compare
No description provided.