Allure steps for bucket_list tests. #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #39 Signed-off-by: Maksim Gelbakhiani <[email protected]>
MaxGelbakhiani
assigned MaxGelbakhiani, roman-khimov, evgeniiz321 and vvarg229 and unassigned MaxGelbakhiani, evgeniiz321 and vvarg229
vvarg229
approved these changes
Nov 2, 2023
roman-khimov
reviewed
Nov 2, 2023
| status, error_code = _get_status_and_error_code(e.response) | ||
| assert status == 409 | ||
| assert error_code == "BucketNotEmpty" | ||
|
|
||
|
|
||
| @allure.step("Do set bucket canned ACL") |
| @@ -1869,6 +2106,7 @@ def _do_set_bucket_canned_acl_concurrent(client, bucket_name, canned_acl, num, r | |||
| return t | |||
|
|
|||
|
|
|||
| @allure.step("Do wait completion") | |||
|
|
||
|
|
||
| @allure.step("Do set ACL concurrent") |
evgeniiz321
reviewed
Nov 3, 2023
| @@ -905,7 +986,10 @@ def test_bucket_listv2_prefix_basic(): | |||
| bucket_name = _create_objects(keys=key_names) | |||
| client = get_client() | |||
|
|
|||
| response = client.list_objects_v2(Bucket=bucket_name, Prefix="foo/") | |||
| req_params = dict(Bucket=bucket_name, Prefix="foo/") | |||
| with allure.step(f"Request list_objects: {req_params}"): | |||
There was a problem hiding this comment.
it is better to wrap client.list_objects_v2 and similar methods with an allure specific code, cause too many duplicates here
There was a problem hiding this comment.
perhaps it is even worth to just create a wrapper for a client class with getattribute overridden, and intercept there every call to methods and log input params and output from them to allure. In this case we won't have too many changes here, but just in a single place in a single wrapper.
There was a problem hiding this comment.
Opened a new PR #57 with client class methods overridden.
Closing this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #39
A set of bucket_list S3 tests wrapped with allure steps.