Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search for objects list, #228

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

mike-petrov
Copy link
Contributor

closes #211

Signed-off-by: Mikhail Petrov [email protected]

@mike-petrov mike-petrov self-assigned this Sep 18, 2024
@mike-petrov
Copy link
Contributor Author

mike-petrov commented Sep 18, 2024

few moments:

  1. Pagination does not work correctly because every time offset parameter is changed a different list of objects is returned. ex offset=0 and offset=10:
Screenshot 2024-09-18 at 23 12 19 Screenshot 2024-09-18 at 23 12 24
  1. Did I choose the right filter for search MatchCommonPrefix? It only works from the beginning of the object name and also it only works with FileName, but if you have FilePath attribute you see it like a name:
image

@tatiana-nspcc @roman-khimov

@tatiana-nspcc
Copy link

  1. Pagination does not work correctly because every time offset parameter is changed a different list of objects is returned. ex offset=0 and offset=10:

Yep, unfortunately, there is no sorting in the search request, so the result with offset is pretty random.

  1. Did I choose the right filter for search MatchCommonPrefix

I don't think we have any other option here, just the prefix.

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a part of #211 in fact. It's OK to have it, but I'd like to see more functionality exposed. The request language is rather rich, we can search by combination of attributes, we can do numeric matches and all of this should be available to users as well. They can add custom attributes right in the panel, so they should be able to make use of them. Specify "color=black" and "color=white", then get all those black cats via search (not name-based).

@mike-petrov mike-petrov force-pushed the feature/211-add_search branch from d9da178 to 5487ba8 Compare November 28, 2024 09:06
@mike-petrov
Copy link
Contributor Author

mike-petrov commented Nov 28, 2024

Functionality:

  • search panel:
Screenshot 2024-11-27 at 21 26 05
  • standart search:
Screenshot 2024-11-27 at 21 25 13
  • attributes search:
Screenshot 2024-11-27 at 21 24 55

@mike-petrov
Copy link
Contributor Author

  • custom attributes search:
Screenshot 2024-11-27 at 21 30 19 Screenshot 2024-11-27 at 21 30 32 Screenshot 2024-11-27 at 21 30 40

@mike-petrov mike-petrov force-pushed the feature/211-add_search branch from 85308fe to d30fee2 Compare December 5, 2024 10:04
@mike-petrov
Copy link
Contributor Author

filter block:

Screenshot 2024-12-05 at 13 14 16

some examples

Screenshot 2024-12-05 at 12 54 29 Screenshot 2024-12-05 at 12 54 48

@mike-petrov mike-petrov force-pushed the feature/211-add_search branch from 95adae8 to e1fbe5e Compare December 5, 2024 17:40
{ value: 'MatchStringEqual', title: 'equal' },
{ value: 'MatchStringNotEqual', title: 'not equal' },
{ value: 'MatchCommonPrefix', title: 'has prefix' },
].map((item) => (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roman-khimov updated, idk about "starts with", which parameter should I use?

@roman-khimov roman-khimov merged commit c643f10 into master Dec 5, 2024
3 checks passed
@roman-khimov roman-khimov deleted the feature/211-add_search branch December 5, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search
3 participants