Add support for OneGate wallet #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Petrov <[email protected]>
|
We have one issue: we can't open and download objects because it's not allowed in a browser type like the wallet. What can we do about it? For example, we can display images in popup and they will be visible, but other types of files are not suitable for displaying. 
|
closes #145 Signed-off-by: Mikhail Petrov <[email protected]>
mike-petrov
force-pushed
the
feature/145-support_onegate_wallet
branch
from
3b65396 to
dfcff32
Compare
| } | ||
| } | ||
|
|
||
| const onDisconnectWallet = async () => { | ||
| await wcSdk.disconnect(); | ||
| if (!dapi) { |
There was a problem hiding this comment.
But what about if dapi? How can we disconnect?
There was a problem hiding this comment.
There is no such method in the documentation, so we just redirect the user to the main page
| height={40} | ||
| alt="download an object" | ||
| /> | ||
| {!window.OneGate && ( |
There was a problem hiding this comment.
The only thing for OneGate is delete? Downloads (with appropriate Content-Disposition) get blocked too?
There was a problem hiding this comment.
Yes, opening a new tab and downloading is not available
roman-khimov
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikhail Petrov [email protected]
closes #145