Skip to content
This repository has been archived by the owner on Mar 29, 2024. It is now read-only.

dev_env: binaries auto download, custom configs for services #92

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

evgeniiz321
Copy link
Contributor

No description provided.

@evgeniiz321 evgeniiz321 self-assigned this Feb 29, 2024
@evgeniiz321 evgeniiz321 force-pushed the ezayats/devenvenhancements branch 3 times, most recently from 4b42548 to 7d4a3d6 Compare February 29, 2024 04:59
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pay attention to commit structure.

Will I be able to provide some local binary?

src/neofs_testlib/env/env.py Outdated Show resolved Hide resolved
src/neofs_testlib/env/env.py Outdated Show resolved Hide resolved
src/neofs_testlib/env/env.py Show resolved Hide resolved
neofs_s3_gw:
repo: 'nspcc-dev/neofs-s3-gw'
version: 'v0.29.0'
file: 'neofs-s3-gw-linux-amd64'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OS/ARCH can be generalized, we use the same scheme for everything now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean you can have $OS and $ARCH and neofs-s3-gw-$OS-$ARCH of some kind.

src/neofs_testlib/env/env.py Outdated Show resolved Hide resolved
src/neofs_testlib/env/env.py Outdated Show resolved Hide resolved
src/neofs_testlib/env/env.py Outdated Show resolved Hide resolved
src/neofs_testlib/env/env.py Show resolved Hide resolved
Evgeniy Zayats added 2 commits February 29, 2024 21:09
@evgeniiz321 evgeniiz321 force-pushed the ezayats/devenvenhancements branch from 7d4a3d6 to fdc9a36 Compare March 1, 2024 02:11
@evgeniiz321
Copy link
Contributor Author

Please pay attention to commit structure.

Will I be able to provide some local binary?

Updated commit structure, now should be better.
For local binaries: if there is already a binary in the local dir, new one will not be downloaded, so we can easily replace it with what we wanted.

Signed-off-by: Evgeniy Zayats <[email protected]>
@roman-khimov roman-khimov merged commit d2a5c65 into master Mar 1, 2024
3 checks passed
@roman-khimov roman-khimov deleted the ezayats/devenvenhancements branch March 1, 2024 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants