Add functionality to deploy custom neofs environments #81
Conversation
closes #nspcc-dev/neofs-testcases#672 Signed-off-by: Evgeniy Zayats <[email protected]>
Signed-off-by: Evgeniy Zayats <[email protected]>
evgeniiz321
requested review from
roman-khimov,
cthulhu-rider and
vvarg229
as code owners
|
|
||
|
|
||
| @pytest.fixture | ||
| def s3_creds(neofs_env: NeoFSEnv, zero_fee, wallet: NodeWallet) -> tuple: |
There was a problem hiding this comment.
In this particular case - yes. But actually any kind of env is configured via this kind of classmethods or fixtures:
@classmethod
def simple(cls) -> "NeoFSEnv":
neofs_env = NeoFSEnv()
neofs_env.deploy_inner_ring_node()
neofs_env.deploy_storage_node()
neofs_env.deploy_s3_gw()
return neofs_env
So we can have whatever we want. But for the purpose of this PR - to have a working example - I use s3 gate here.
| self.neofs_s3_authmate_path = os.getenv("NEOFS_S3_AUTHMATE_BIN", "./neofs-s3-authmate") | ||
| self.neofs_s3_gw_path = os.getenv("NEOFS_S3_GW_BIN", "./neofs-s3-gw") | ||
| self.neofs_rest_gw_path = os.getenv("NEOFS_REST_GW_BIN", "./neofs-rest-gw") | ||
| self.neofs_http_gw_path = os.getenv("NEOFS_HTTP_GW_BIN", "./neofs-http-gw") |
There was a problem hiding this comment.
I'd better have gateways defined separately somewhere, many tests don't care about them at all. Those who care, should just run an instance as needed.
There was a problem hiding this comment.
This is not a definition of gateways, it is just the way to organize env vars in one place. If tests don't care - they won't use it, there is no requirement to specify any of these env vars. Gateways are indeed separate classes (you can see the class for s3 gateway in this PR). I can move related paths there, but it seems to be more convenient to have them in one place.
Closes nspcc-dev/neofs-testcases#672
I've tried to remove as much code as possible to ease the review. In this PR:
Everything should be self descriptive without additional comments, if not - leave a comment.