Update skipped s3 tests #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some s3 tests are required to run with specific client - either boto3 or plain aws cli. To prevent generation of useless tests that are skipped parametrization func was updated to handle it via markers. Signed-off-by: Evgeniy Zayats <[email protected]>
evgeniiz321
requested review from
roman-khimov,
cthulhu-rider and
vvarg229
as code owners
Signed-off-by: Evgeniy Zayats <[email protected]>
evgeniiz321
force-pushed
the
fix-s3-tests
branch
from
fbd8e00 to
8849048
Compare
vvarg229
approved these changes
Nov 15, 2023
roman-khimov
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ACL tests are failing, but should be fixed by #669