internal/proto: Fix encoding of zero embedded messages #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While an unspecified (nil) embedded field of `message` protobuf type is encoded as nothing, the zero is still reflected in the message as an encoded field number plus zero. This fixes the test and makes correct assertion of zero message encoding. The tests fails meaning there is a bug for now. The test is also made independent with the nil one to make the not fail each other. Signed-off-by: Leonard Lyubich <[email protected]>
Fixes the problem detected in d44ef3b via `reflect` package as well as `neofs-api-go` module does. Another way would be to check each field in the implementation of `MarshalStable([]byte)` interface, but this would add a significant amount of code. Benchmark showed almost no performance loss: ``` goos: linux goarch: amd64 pkg: github.com/nspcc-dev/neofs-sdk-go/internal/proto cpu: Intel(R) Core(TM) i5-10210U CPU @ 1.60GHz │ old.txt │ new.txt │ │ sec/op │ sec/op vs base │ MarshalEmbedded-8 26.00n ± 31% 27.59n ± 2% ~ (p=0.393 n=10) │ old.txt │ new.txt │ │ B/op │ B/op vs base │ MarshalEmbedded-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹ ¹ all samples are equal │ old.txt │ new.txt │ │ allocs/op │ allocs/op vs base │ MarshalEmbedded-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹ ¹ all samples are equal ``` Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
requested review from
roman-khimov,
smallhive and
carpawell
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #672 +/- ##
==========================================
+ Coverage 58.77% 60.93% +2.15%
==========================================
Files 165 165
Lines 22751 22810 +59
==========================================
+ Hits 13372 13899 +527
+ Misses 8940 8544 -396
+ Partials 439 367 -72 ☔ View full report in Codecov by Sentry. |
|
decided to checrry-pick into #667 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/nspcc-dev/neofs-api-go/v2module #667