Reuse buffers #525
Merged
Reuse buffers #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallhive
force-pushed
the
optimize-signature
branch
from
9764219 to
7506302
Compare
smallhive
requested review from
roman-khimov,
cthulhu-rider and
carpawell
as code owners
roman-khimov
reviewed
Oct 9, 2023
Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
optimize-signature
branch
3 times, most recently
from
556edf6 to
1e4ddb2
Compare
The buffer will be used to avoid new allocations during signing GRPC messages. Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
optimize-signature
branch
from
1e4ddb2 to
dd4e3e0
Compare
| @@ -13,6 +14,11 @@ import ( | |||
| "github.com/nspcc-dev/neofs-sdk-go/stat" | |||
| ) | |||
|
|
|||
| const ( | |||
| // max GRPC message size. | |||
| defaultBufferSize = 4194304 // 4MB | |||
There was a problem hiding this comment.
https://github.com/grpc/grpc-go/blob/bf05b9558c16677e362d231120f8213eb276d406/server.go#L58
But it's not exported, true. Which is bad.
roman-khimov
approved these changes
Oct 16, 2023
carpawell
reviewed
Oct 23, 2023
| @@ -13,6 +14,11 @@ import ( | |||
| "github.com/nspcc-dev/neofs-sdk-go/stat" | |||
| ) | |||
|
|
|||
| const ( | |||
| // max GRPC message size. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.