Return header directly instead of wrapper struct #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
reviewed
Aug 22, 2023
client/object_get.go
Outdated
| @@ -349,7 +349,7 @@ type ResObjectHead struct { | |||
|
|
|||
| // ReadHeader reads header of the requested object. | |||
| // Returns false if header is missing in the response (not read). | |||
| func (x *ResObjectHead) ReadHeader(dst *object.Object) bool { | |||
| func (x *resObjectHead) ReadHeader(dst *object.Object) bool { | |||
There was a problem hiding this comment.
resObjectHead is private, so it doesn't matter much.
There was a problem hiding this comment.
sure but usually when i see public methods on a private struct i think that it implements something and all. that is just an internal converter. if there is no external tests for it, i suggest to make it private. do not insist
smallhive
force-pushed
the
487-objecthead-must-return-object-header
branch
from
dd3557d to
b82cdc8
Compare
|
Removed resObjectHead completely |
|
So to draft or not to draft? That is the question. |
|
No draft, of course 😅 |
roman-khimov
approved these changes
Aug 23, 2023
carpawell
approved these changes
Aug 23, 2023
|
Conflicts after #491 merge. |
Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
487-objecthead-must-return-object-header
branch
from
b82cdc8 to
25d5593
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #487