Remove parameter fullBearerToken
#238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #238 +/- ##
==========================================
+ Coverage 21.88% 22.12% +0.24%
==========================================
Files 17 17
Lines 3583 3507 -76
==========================================
- Hits 784 776 -8
+ Misses 2639 2579 -60
+ Partials 160 152 -8 ☔ View full report in Codecov by Sentry. |
|
Rebase, please. |
This parameter indicates that a binary bearer token was requested via the `/auth/bearer` request and is being used instead of wallet connect. However, it's not difficult to detect this without the `fullBearer` parameter. If the `X-Bearer-Signature` and `X-Bearer-Signature-Key` are absent in the request header, we can assume that the received token is `fullBearer`. Signed-off-by: Tatiana Nesterenko <[email protected]>
tatiana-nspcc
force-pushed
the
remove-param-full-bearer
branch
from
749c40d to
81f29af
Compare
|
Rebased to a current master state. |
smallhive
approved these changes
Aug 19, 2024
roman-khimov
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #236 and to the comment nspcc-dev/panel-fs-neo-org#217 (comment)