morph: fix nil pointer dereferencing to connection #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3073 +/- ##
=======================================
Coverage 22.42% 22.42%
=======================================
Files 792 792
Lines 58535 58538 +3
=======================================
+ Hits 13129 13130 +1
- Misses 44505 44507 +2
Partials 901 901 ☔ View full report in Codecov by Sentry. |
End-rey
force-pushed
the
3061-panic-sighup-switch-rpc-node
branch
from
e6a0a4e to
5df74ac
Compare
End-rey
force-pushed
the
3061-panic-sighup-switch-rpc-node
branch
from
5df74ac to
1e7896e
Compare
roman-khimov
approved these changes
Dec 26, 2024
|
Needs a rebase because of CHANGELOG conflict. |
When the RPC connection is lost and a recovery attempt occurs, the variable `conn` responsible for the connection may be nil and therefore additional verification is needed. Closes #3061. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
3061-panic-sighup-switch-rpc-node
branch
from
1e7896e to
48d09ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the RPC connection is lost and a recovery attempt occurs, the variable
connresponsible for the connection may be nil and therefore additional verification is needed.I couldn't come up with a better solution, so I'm open to smart thoughts.
Closes #3061.