node, ir: rename morph config to fschain
#3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
End-rey
force-pushed
the
3021-rename-morph-config-to-fschain
branch
from
58241c9 to
c4c54cd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3028 +/- ##
==========================================
+ Coverage 22.62% 22.65% +0.02%
==========================================
Files 791 791
Lines 58531 58618 +87
==========================================
+ Hits 13244 13277 +33
- Misses 44389 44445 +56
+ Partials 898 896 -2 ☔ View full report in Codecov by Sentry. |
These are DB keys, not a big problem. |
carpawell
reviewed
Nov 25, 2024
Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
3021-rename-morph-config-to-fschain
branch
from
c4c54cd to
dd416b0
Compare
carpawell
reviewed
Nov 26, 2024
| // migration for deprecated DB key | ||
| if fromFSChainBlock == 0 && fromDeprectedSidechanBlock != fromFSChainBlock { | ||
| fromFSChainBlock = fromDeprectedSidechanBlock | ||
| err = server.persistate.SetUInt32(persistateFSChainLastBlockKey, fromFSChainBlock) |
There was a problem hiding this comment.
should we drop the previous value? @roman-khimov
There was a problem hiding this comment.
Why keeping it? No one cares, can be dropped.
Signed-off-by: Andrey Butusov <[email protected]>
Rename the `morph` section in the code, config and examples to `fschain`. Maintain compatibility for the transition and warn if `morph` is used. Migrate data for deprecated DB key to new. Refs #3021. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
3021-rename-morph-config-to-fschain
branch
from
dd416b0 to
0d6d425
Compare
roman-khimov
approved these changes
Nov 26, 2024
|
Tests need to be fixed.
We need to keep compatibility here as well. |
Leave compatibility with the `morph` command and warn if it executes. Refs #2702. Signed-off-by: Andrey Butusov <[email protected]>
Signed-off-by: Andrey Butusov <[email protected]>
Rename the `morph` section in the code, config and examples to `fschain`. Maintain compatibility for the transition and warn if `morph` is used. Migrate data for deprecated DB key to new. Closes #3021. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
3021-rename-morph-config-to-fschain
branch
from
0d6d425 to
67d82d2
Compare
End-rey
added a commit
to nspcc-dev/neofs-testcases
that referenced
this pull request
Nov 27, 2024
After this nspcc-dev/neofs-node#3028, the `morph` was renamed to `fschain`. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
added a commit
to nspcc-dev/neofs-testcases
that referenced
this pull request
Nov 27, 2024
After this nspcc-dev/neofs-node#3028, the `morph` was renamed to `fschain`. Signed-off-by: Andrey Butusov <[email protected]>
carpawell
approved these changes
Nov 27, 2024
End-rey
added a commit
to nspcc-dev/neofs-testcases
that referenced
this pull request
Nov 28, 2024
After this nspcc-dev/neofs-node#3028, the `morph` was renamed to `fschain`. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
added a commit
to nspcc-dev/neofs-testcases
that referenced
this pull request
Nov 28, 2024
After this nspcc-dev/neofs-node#3028, the `morph` was renamed to `fschain`. Signed-off-by: Andrey Butusov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3021.
Not sure about
neofs-node/pkg/innerring/state.go
Line 22 in 3f6d545
and
neofs-node/cmd/neofs-node/config.go
Line 525 in 3f6d545