Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify engine internals #3010

Merged
merged 5 commits into from
Nov 13, 2024

engine: unify GetRange implementation with Get

99d4320
Select commit
Loading
Failed to load commit list.
Merged

Simplify engine internals #3010

engine: unify GetRange implementation with Get
99d4320
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 12, 2024 in 0s

22.83% (-0.16%) compared to 6ea74d2, passed because coverage increased by 0.15% when compared to adjusted base (22.68%)

View this Pull Request on Codecov

22.83% (-0.16%) compared to 6ea74d2, passed because coverage increased by 0.15% when compared to adjusted base (22.68%)

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 162 lines in your changes missing coverage. Please review.

Project coverage is 22.83%. Comparing base (6ea74d2) to head (99d4320).

Files with missing lines Patch % Lines
pkg/local_object_storage/engine/inhume.go 45.31% 33 Missing and 2 partials ⚠️
pkg/local_object_storage/engine/container.go 0.00% 31 Missing ⚠️
pkg/local_object_storage/engine/select.go 16.66% 19 Missing and 1 partial ⚠️
pkg/local_object_storage/engine/lock.go 48.38% 15 Missing and 1 partial ⚠️
pkg/local_object_storage/engine/get.go 78.87% 9 Missing and 6 partials ⚠️
pkg/local_object_storage/engine/status.go 0.00% 9 Missing ⚠️
pkg/local_object_storage/engine/head.go 72.00% 7 Missing ⚠️
pkg/local_object_storage/engine/tree.go 0.00% 7 Missing ⚠️
pkg/local_object_storage/engine/exists.go 25.00% 5 Missing and 1 partial ⚠️
pkg/local_object_storage/engine/put.go 64.28% 4 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3010      +/-   ##
==========================================
- Coverage   22.99%   22.83%   -0.16%     
==========================================
  Files         790      790              
  Lines       58500    58342     -158     
==========================================
- Hits        13454    13325     -129     
+ Misses      44167    44136      -31     
- Partials      879      881       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov