control: set the highest priority for control service. #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2645 +/- ##
==========================================
- Coverage 30.62% 30.61% -0.01%
==========================================
Files 406 406
Lines 30070 30070
==========================================
- Hits 9208 9206 -2
- Misses 20085 20086 +1
- Partials 777 778 +1 ☔ View full report in Codecov by Sentry. |
AliceInHunterland
force-pushed
the
control_service
branch
from
63c35c4 to
d962250
Compare
carpawell
reviewed
Nov 15, 2023
AliceInHunterland
force-pushed
the
control_service
branch
from
d962250 to
b9c1a5b
Compare
AliceInHunterland
changed the title
AliceInHunterland
force-pushed
the
control_service
branch
from
b9c1a5b to
e9c7422
Compare
|
Needs to be rebased. |
AliceInHunterland
force-pushed
the
control_service
branch
from
e9c7422 to
a595390
Compare
cthulhu-rider
requested changes
Nov 17, 2023
CHANGELOG.md
Outdated
| @@ -26,6 +26,7 @@ Changelog for NeoFS Node | |||
| - IR uses internal LOCODE DB from Go package (#2610) | |||
| - Contract group for the committee is no longer registered/used in the Sidechain auto-deployment (#2642) | |||
| - The priority of metrics service is increased (#2428) | |||
| - The priority of running control service is increased (#2585) | |||
There was a problem hiding this comment.
if set the highest priority, then maximized
pkg/innerring/innerring.go
Outdated
| grpcControlSrv := grpc.NewServer() | ||
| control.RegisterControlServiceServer(grpcControlSrv, controlSvc) | ||
|
|
||
| lis, err := net.Listen("tcp", controlSvcEndpoint) |
There was a problem hiding this comment.
err is lost
btw best to start listening immediately after parsing the keys in order to respond to an error as early as possible, and only if everything is ok - init gRPC server
Control ports should be initialised and start served first of all. The priority of running control service is maximized for both SN and IR. Closes: #2585. Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
control_service
branch
from
a595390 to
5815476
Compare
carpawell
approved these changes
Nov 20, 2023
cthulhu-rider
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2585.