locode: update with new locodedb package #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
force-pushed
the
2610_new_locode_package
branch
3 times, most recently
from
9913e55 to
b692b5a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2634 +/- ##
==========================================
+ Coverage 28.54% 28.67% +0.12%
==========================================
Files 421 415 -6
Lines 32481 32234 -247
==========================================
- Hits 9272 9242 -30
+ Misses 22401 22196 -205
+ Partials 808 796 -12
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
AliceInHunterland
force-pushed
the
2610_new_locode_package
branch
2 times, most recently
from
edd66c3 to
7e09b41
Compare
AliceInHunterland
force-pushed
the
2610_new_locode_package
branch
from
7e09b41 to
2b929b1
Compare
AliceInHunterland
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
roman-khimov
reviewed
Nov 9, 2023
pkg/innerring/processors/netmap/nodevalidation/locode/calls_test.go
Outdated
Show resolved
Hide resolved
AliceInHunterland
force-pushed
the
2610_new_locode_package
branch
from
2b929b1 to
5541dc9
Compare
roman-khimov
reviewed
Nov 9, 2023
AliceInHunterland
force-pushed
the
2610_new_locode_package
branch
from
5541dc9 to
0385d6a
Compare
AliceInHunterland
force-pushed
the
2610_new_locode_package
branch
2 times, most recently
from
4c0b0d2 to
03129eb
Compare
|
It needs a rebase as well. |
AliceInHunterland
force-pushed
the
2610_new_locode_package
branch
from
03129eb to
5b31fa2
Compare
roman-khimov
approved these changes
Nov 11, 2023
|
Needs a rebase now. |
AliceInHunterland
force-pushed
the
2610_new_locode_package
branch
from
5b31fa2 to
270eb0a
Compare
Removed command connected to locodedb generation. Import the new package into IR and CLI to do the same checks and queries. Removed IR DB configuration option. Refs: #2610. Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
2610_new_locode_package
branch
from
270eb0a to
fcf32d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports branch version with a new locodedb package, should be changed after merging #22.
Refs: #2610.