Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go fmt generated code #356

Merged
merged 1 commit into from
Nov 20, 2023
Merged

go fmt generated code #356

merged 1 commit into from
Nov 20, 2023

Conversation

cthulhu-rider
Copy link
Contributor

@cthulhu-rider cthulhu-rider commented Sep 18, 2023 •
edited
Loading

btw we can go further and use goimports tool since imports are unsorted, but i decided to not do that for now

with these changes make fmt (go fmt ./...) becomes no-op

roman-khimov
roman-khimov reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need it? These are used for imports and doc generation, they're not supposed to be looked at.

@cthulhu-rider
Copy link
Contributor Author

Do we really need it? These are used for imports and doc generation, they're not supposed to be looked at.

not a big problem, but clean go fmt ./... out is nice imo

maybe this will inspire generator to use https://pkg.go.dev/go/[email protected]#Source

@roman-khimov
Copy link
Member

Huh, that's exactly what I was looking for. But for some reason gofmt works a bit differently, or maybe I wasn't looking deep enough. Yes, I think we better do this at the generator level (just in case anyone still wants to have a look), please file an issue.

@cthulhu-rider cthulhu-rider marked this pull request as draft September 18, 2023 12:13
@cthulhu-rider cthulhu-rider mentioned this pull request Sep 18, 2023
Closed
@cthulhu-rider cthulhu-rider added the blocked Can't be done because of something label Sep 18, 2023
@carpawell
Copy link
Member

Not needed after nspcc-dev/neo-go#3164?

@roman-khimov
Copy link
Member

Likely so.

@cthulhu-rider
README: Increase Neo Go version required for the compilation
bccd988 
New min version includes various enhancements/fixes incl. Go-formatted
codegen.

Also mention upgrade in the CHANGELOG.

Refs #367 (73882ca).

Signed-off-by: Leonard Lyubich <[email protected]>
@cthulhu-rider cthulhu-rider marked this pull request as ready for review November 20, 2023 14:34
@cthulhu-rider
Copy link
Contributor Author

updated prerequisities with corresponding Neo Go version

@roman-khimov roman-khimov merged commit 3f566f8 into master Nov 20, 2023
8 checks passed
@roman-khimov roman-khimov deleted the codegen-fmt branch November 20, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@AnnaShaleva AnnaShaleva Awaiting requested review from AnnaShaleva

@carpawell carpawell Awaiting requested review from carpawell carpawell is a code owner

Assignees
No one assigned
Labels
blocked Can't be done because of something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cthulhu-rider @roman-khimov @carpawell