Archival node #3778
Merged
Archival node #3778
+119
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's the way it's defined and used in C#, see neo-project/neo#3639 also. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
archival-node
branch
from
916444f to
a129a81
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3778 +/- ##
==========================================
+ Coverage 83.13% 83.16% +0.03%
==========================================
Files 335 335
Lines 46855 46873 +18
==========================================
+ Hits 38954 38984 +30
+ Misses 6311 6299 -12
Partials 1590 1590 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Dec 28, 2024
roman-khimov
force-pushed
the
archival-node
branch
from
a129a81 to
e36b28a
Compare
AnnaShaleva
reviewed
Dec 28, 2024
Follow neo-project/neo#3639. Signed-off-by: Roman Khimov <[email protected]>
It's more symmetric than the C# counterpart, but the essence is the same: we can accept capabilities we can't interpret. Refs. neo-project/neo#3639 Signed-off-by: Roman Khimov <[email protected]>
This will be used to differentiate full history nodes from state only. Currently it's just a definition, we can not use it safely on current networks because nodes will refuse this Version, so actual code using the attribute will be added in newer versions. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
archival-node
branch
from
e36b28a to
82b4007
Compare
AnnaShaleva
added a commit
to neo-project/neo
that referenced
this pull request
Dec 28, 2024
Otherwise it can't be properly passed through the P2P network which makes it impossible to use UnknownCapabilities as an extensions in the existing networks. Follow nspcc-dev/neo-go#3778. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
added a commit
to neo-project/neo
that referenced
this pull request
Dec 28, 2024
Without this commit every `Addr` message containing UnknownCapability will be considered as invalid. The desired behaviour is to include node with UnknownCapability into the list of peers. Follow the nspcc-dev/neo-go#3778, should be a part of #3639. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
added a commit
to neo-project/neo
that referenced
this pull request
Dec 28, 2024
Make the behaviour compatible with nspcc-dev/neo-go#3778. Signed-off-by: Anna Shaleva <[email protected]>
15 tasks
|
Please, check neo-project/neo#3647, from the current implementation it seems to me that UnknownCapability can be passed through the network without any restrictions, which is correct, but prohibited in C# node. |
|
It's mentioned in commits and |
AnnaShaleva
reviewed
Dec 28, 2024
AnnaShaleva
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.