Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: NNS update, part 5 #2693

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

examples: NNS update, part 5 #2693

wants to merge 16 commits into from

Conversation

AnnaShaleva
Copy link
Member

Depends on #2687.

@AnnaShaleva
nns: adjust maxDomainNameFragmentLength
bd37220 
Port nspcc-dev/neofs-contract#238.
@AnnaShaleva
nns: allow hyphen in domain names
c11481b 
Port nspcc-dev/neofs-contract#183.
@AnnaShaleva
nns: replace root with TLD
5cb2a12 
Port
nspcc-dev/neofs-contract@4b86891.
@AnnaShaleva
nns: require admin signature for subdomain registration
017a6b9 
Port
nspcc-dev/neofs-contract@14fc086.
@AnnaShaleva
nns: check domain expiration for read functions
baf24d1 
Port nspcc-dev/neofs-contract@432c02a.
@AnnaShaleva
nns: allow to resolve FQDN
225152f 
Port nspcc-dev/neofs-contract@4041924.
@AnnaShaleva
nns: add admin to properties
d77b35c 
See https://github.com/neo-project/non-native-contracts/blob/14f43ba8cf169323b61c23a3a701ac77d9a4e3eb/src/NameService/NameService.cs#L69.
@AnnaShaleva
*: update basic test chain
4543de0 
Apply new NNS rules.
@AnnaShaleva
nns: add test for getAllRecords
c296f88
@AnnaShaleva
nns: allow multiple records of the same type
c9050ce 
Except for the CNAME records. Port
nspcc-dev/neofs-contract@6ea4573
and
nspcc-dev/neofs-contract@f4762c1.
@AnnaShaleva
nns: ensure records with the same type are not repeated
8790602 
Port nspcc-dev/neofs-contract#170.
@codecov
Copy link

codecov bot commented Sep 15, 2022 •
edited
Loading

Codecov Report

Merging #2693 (14c9858) into master (20224cb) will increase coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2693      +/-   ##
==========================================
+ Coverage   85.23%   85.43%   +0.20%     
==========================================
  Files         322      322              
  Lines       39398    39680     +282     
==========================================
+ Hits        33580    33900     +320     
+ Misses       4479     4455      -24     
+ Partials     1339     1325      -14
Impacted Files Coverage Δ
pkg/services/oracle/oracle.go 72.99% <0.00%> (-14.51%) ⬇️
pkg/services/oracle/request.go 58.18% <0.00%> (-4.84%) ⬇️
pkg/services/stateroot/network.go 76.71% <0.00%> (-0.32%) ⬇️
pkg/services/oracle/response.go 84.80% <0.00%> (-0.24%) ⬇️
pkg/network/server.go 73.08% <0.00%> (-0.17%) ⬇️
pkg/neorpc/errors.go 69.69% <0.00%> (ø)
pkg/rpcclient/nep11.go 0.00% <0.00%> (ø)
pkg/consensus/crypto.go 100.00% <0.00%> (ø)
pkg/rpcclient/policy.go 65.38% <0.00%> (ø)
pkg/util/slice/array.go 100.00% <0.00%> (ø)
... and 45 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AnnaShaleva AnnaShaleva changed the title examples: NNS update, part 3 examples: NNS update, part 5 Sep 16, 2022
@AnnaShaleva AnnaShaleva mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov will be requested when the pull request is marked ready for review roman-khimov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AnnaShaleva