Org-wide linter #154
Merged
Org-wide linter #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-notary is long gone for NeoFS. pkg/morphchain/contracts/netmap.go:26:3: field `notaryDisabled` is unused (unused) Signed-off-by: Roman Khimov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #154 +/- ##
======================================
Coverage 3.03% 3.03%
======================================
Files 18 18
Lines 987 987
======================================
Hits 30 30
Misses 955 955
Partials 2 2 ☔ View full report in Codecov by Sentry. |
End-rey
requested changes
Sep 10, 2024
Makefile
Outdated
| @@ -36,8 +36,11 @@ clean: | |||
| version: | |||
| @echo ${VERSION} | |||
|
|
|||
| .golangci.yml: | |||
| wget -O $@ https://github.com/nspcc-dev/.github/raw/master/.golangci.yml | |||
There was a problem hiding this comment.
with spaces, it doesn't work for me
Adjust Makefile to fetch appropriate .golangci.yml. Signed-off-by: Roman Khimov <[email protected]>
cmd/neo-exporter/config.go:14:25 godot Comment should end in a period cmd/neo-exporter/config.go:17:39 godot Comment should end in a period cmd/neo-exporter/config.go:26:44 godot Comment should end in a period Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
org-linter
branch
from
c36dff9 to
5c5f83e
Compare
End-rey
approved these changes
Sep 10, 2024
carpawell
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.