Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default connection timeout #152

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Increase default connection timeout #152

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8303c4
config: set the default rpc dial timeout to 1 minute
End-rey Aug 29, 2024
8bfceb6
config: edit `chain.rpc.dial_timeout` to 60 sec in the example file
End-rey Aug 29, 2024
34afd00
config: set the default metrics interval to 15 sec
End-rey Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/neo-exporter/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const (

func DefaultConfiguration(cfg *viper.Viper) {
cfg.SetDefault(prefix+delimiter+cfgNeoRPCEndpoint, "")
cfg.SetDefault(prefix+delimiter+cfgNeoRPCDialTimeout, 5*time.Second)
cfg.SetDefault(prefix+delimiter+cfgNeoRPCDialTimeout, time.Minute)
roman-khimov marked this conversation as resolved.
Show resolved Hide resolved

cfg.SetDefault(cfgMetricsEndpoint, ":16512")
cfg.SetDefault(cfgMetricsInterval, 15*time.Minute)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is for timeout changes, let's add one more commit and change this to 15*time.Second.
The example YAML config contains 15s and I doubt 15 minutes is a good interval between metric gathering for default value 😅

Expand Down