Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version metric #143

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Version metric #143

merged 3 commits into from
Jun 19, 2024

Conversation

roman-khimov
Copy link
Member

This also fixes some neofs_net_monitor remnants.

And make it a namespace, we may want to use subsystems for something else.
This change was missing from the original net monitor to exporter rename.

Signed-off-by: Roman Khimov <[email protected]>
@roman-khimov roman-khimov requested review from 532910 and smallhive June 19, 2024 08:56
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 3.04%. Comparing base (24589cb) to head (dd340db).
Report is 4 commits behind head on master.

Files Patch % Lines
pkg/monitor/metrics.go 0.00% 4 Missing ⚠️
cmd/neo-exporter/monitor.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #143      +/-   ##
=========================================
- Coverage    3.07%   3.04%   -0.03%     
=========================================
  Files          18      18              
  Lines         975     984       +9     
=========================================
  Hits           30      30              
- Misses        943     952       +9     
  Partials        2       2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roman-khimov roman-khimov merged commit 5030d49 into master Jun 19, 2024
15 of 17 checks passed
@roman-khimov roman-khimov deleted the version-metric branch June 19, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants