close #110, remove outdated config.env #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be updated, not deleted. |
|
|
OK, after discussion with @smallhive we agreed to drop it for now, but to deal with #110 we also need to update Docker configs. |
smallhive
approved these changes
Mar 1, 2024
|
Docker is still not updated. |
532910
force-pushed
the
remove-outdated-env
branch
from
9600529 to
7398478
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
======================================
Coverage 3.09% 3.09%
======================================
Files 18 18
Lines 970 970
======================================
Hits 30 30
Misses 938 938
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Please update README then, it still mentions Docker. |
532910
force-pushed
the
remove-outdated-env
branch
from
7398478 to
f0f7cda
Compare
|
Still mentions Docker. We also have targets in Makefile. |
532910
force-pushed
the
remove-outdated-env
branch
from
f0f7cda to
653acec
Compare
Signed-off-by: Sеrgiо Nеmirоwski <[email protected]>
532910
force-pushed
the
remove-outdated-env
branch
from
653acec to
425fd8f
Compare
roman-khimov
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.