Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add additional check for navigator.keyboard #9

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented Jul 12, 2024

I noticed this error pops up in our Sofie logs from time to time:

Client error, Sorensen.init, TypeError: TypeError: Cannot read properties of undefined (reading 'addEventListener'), TypeError: Cannot read properties of undefined (reading 'addEventListener')

The error originates from https://github.com/nrkno/sorensen/blob/main/src/index.ts#L661

I have no more info than this, but it seems that navigator.keyboard must have been set, but have the value undefined in some browser?

Anyway, this fix should fix that issue (fingers crossed).

@nytamin nytamin requested a review from a team July 12, 2024 05:52
@nytamin nytamin merged commit 66c30b0 into main Aug 12, 2024
2 checks passed
@nytamin nytamin deleted the fix/keyboard-navigator-undefined branch August 12, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants