Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vMix): support setting text in vMix titles #359

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

ianshade
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of TV 2 Norge

Type of Contribution

This is a:

Feature

Current Behavior

Text fields in Title inputs in vMix cannot be controlled by TSR.

New Behavior

Text fields in Title inputs in vMix can be controlled, using the newly added text property of TimelineContentVMixInput. They can only be addressed by the field name (a.k.a selected name), not by the index.

Testing Instructions

  1. Add a Title input
  2. Create a mapping and a timeline object similar to those in the 'supports text' test case, using field names existing in the selected title template
  3. Verify that the values for specified field names change when the timeline object starts

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@ianshade ianshade requested a review from a team as a code owner November 26, 2024 23:35
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.91%. Comparing base (ad41ae6) to head (65b0dcc).

Files with missing lines Patch % Lines
...state-resolver/src/integrations/vmix/connection.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52     #359      +/-   ##
=============================================
+ Coverage      56.86%   56.91%   +0.05%     
=============================================
  Files            131      131              
  Lines          10293    10308      +15     
  Branches        2575     2581       +6     
=============================================
+ Hits            5853     5867      +14     
- Misses          4074     4439     +365     
+ Partials         366        2     -364     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianshade
Copy link
Contributor Author

Merge conflicts were resolved

@jstarpl jstarpl merged commit 97957d7 into nrkno:release52 Dec 10, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants