Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vMix): support browser source url in vMix #357

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

ianshade
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of TV 2 Norge

Type of Contribution

This is a:

Feature

Current Behavior

URL of the Browser input in vMix can not be controlled by TSR

New Behavior

URL of the Browser input in vMix can be controlled using the added url property of TimelineContentVMixInput.
There is a limitation: The URL can't be read via the API, therefore (re)start or reconnection may issue a BrowserNavigate command even if the URL is already as expected

Testing Instructions

  1. Add a Browser input to vMix
  2. Create a mapping and a timeline object as shown in the 'supports url' test case
  3. Verify if the URL has changed when the timeline object started

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@ianshade ianshade requested a review from a team as a code owner November 26, 2024 20:35
@nytamin nytamin merged commit 842fbf3 into nrkno:release52 Nov 27, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants