fix(sisyfos): Use nullish check rather than or on channel reset #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC.
Type of Contribution
Bug fix
Current Behavior
When setting a full Sisyfos channel state falsy values (E.G. a fader level of 0) will cause the default to be sent instead of the desired value.
New Behavior
The correct value is sent
Testing Instructions
triggerValue
on an individual channel) with a fader level of 0 and verify that Sisyfos receives 0 as expectedOther Information
Status