Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sisyfos): Use nullish check rather than or on channel reset #353

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

PeterC89
Copy link
Contributor

@PeterC89 PeterC89 commented Oct 4, 2024

About the Contributor

This pull request is posted on behalf of the BBC.

Type of Contribution

Bug fix

Current Behavior

When setting a full Sisyfos channel state falsy values (E.G. a fader level of 0) will cause the default to be sent instead of the desired value.

New Behavior

The correct value is sent

Testing Instructions

  • Trigger a set channel command (E.G. with triggerValue on an individual channel) with a fader level of 0 and verify that Sisyfos receives 0 as expected

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@PeterC89 PeterC89 requested a review from a team as a code owner October 4, 2024 08:37
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.60%. Comparing base (59f6d37) to head (65a73c5).

Files with missing lines Patch % Lines
...te-resolver/src/integrations/sisyfos/connection.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           release52     #353    +/-   ##
===========================================
  Coverage      56.60%   56.60%            
===========================================
  Files            131      131            
  Lines          10265    10265            
  Branches        2503     2563    +60     
===========================================
  Hits            5810     5810            
+ Misses          4453     4087   -366     
- Partials           2      368   +366     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nytamin nytamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll cherry-pick this bug fix into release51 as well

@nytamin nytamin merged commit 9059269 into nrkno:release52 Oct 7, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants