Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: atem supersource border properties SOFIE-3307 #341

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

Julusian
Copy link
Member

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Bug fix

Current Behavior

Trying to set the atem supersource border properties has no effect

Testing Instructions

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian requested a review from a team as a code owner August 14, 2024 15:02
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.57%. Comparing base (db19ee3) to head (071869b).
Report is 3 commits behind head on master.

Files Patch % Lines
...line-state-resolver/src/integrations/atem/index.ts 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
- Coverage   37.58%   37.57%   -0.01%     
==========================================
  Files         106      106              
  Lines       10247    10249       +2     
  Branches     2500     2502       +2     
==========================================
  Hits         3851     3851              
  Misses       5848     5848              
- Partials      548      550       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian merged commit 27213b0 into master Aug 15, 2024
32 of 36 checks passed
@Julusian Julusian deleted the fix/atem-supersource-border branch August 15, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants