feat: implement VISCA over IP and Panasonic PTZ actions

[ianshade]

About the Contributor

This PR is opened on behalf of TV 2 Norge.

Type of Contribution

This is a:

Feature (including some Code improvements)

Current Behavior

• No Actions on Panasonic PTZ integration
• No VISCA over IP integration at all

New Behavior

• PTZ actions are added to the Panasonic PTZ integration
• VISCA over IP integration is added, featuring just PTZ actions

Testing Instructions

Other Information

VISCA over IP integration is based on a fixed and refactored version of https://github.com/nrkno/sofie-sony-visca-connection

Status

• PR is ready to be reviewed.
• The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 64.79903% with 289 lines in your changes missing coverage. Please review.

Project coverage is 57.12%. Comparing base (3e5de55) to head (9c024ae).

Files with missing lines	Patch %	Lines
.../integrations/viscaOverIP/connection/lib/socket.ts	4.13%	102 Missing and 14 partials ⚠️
...te-resolver/src/integrations/panasonicPTZ/index.ts	6.57%	70 Missing and 1 partial ⚠️
...ate-resolver/src/integrations/viscaOverIP/index.ts	18.18%	63 Missing ⚠️
...r/src/integrations/viscaOverIP/connection/visca.ts	13.63%	18 Missing and 1 partial ⚠️
.../viscaOverIP/connection/lib/ViscaValueConverter.ts	93.65%	4 Missing ⚠️
...solver/src/integrations/panasonicPTZ/connection.ts	80.00%	3 Missing ⚠️
...nnection/commands/control/resetSeqNumberCommand.ts	50.00%	2 Missing ⚠️
...ection/commands/inquiry/focusModeInquiryCommand.ts	66.66%	2 Missing ⚠️
...on/commands/inquiry/focusPositionInquiryCommand.ts	71.42%	2 Missing ⚠️
.../commands/inquiry/panTiltPositionInquiryCommand.ts	75.00%	2 Missing ⚠️
... and 3 more

Additional details and impacted files

@@              Coverage Diff              @@
##           release52     #340      +/-   ##
=============================================
+ Coverage      56.55%   57.12%   +0.57%     
=============================================
  Files            131      160      +29     
  Lines          10274    10908     +634     
  Branches        2509     2657     +148     
=============================================
+ Hits            5810     6231     +421     
+ Misses          4462     4291     -171     
- Partials           2      386     +384     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nytamin]

Implementation looks good! This is going to be a great addition!

One note for the future: Maybe we should think about (and write documentation for) whether executing an action should affect the internal state or not.