Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sisyfos add fade time during reset #339

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

mint-dewit
Copy link
Contributor

Type of Contribution

This is a: Bug fix

Current Behavior

TSR will not send the fadeTime parameter for PGM changes when the change comes from a triggerValue change

New Behavior

TSR send the fadeTime paramter for PGM changes during a channel reset

@mint-dewit mint-dewit requested a review from a team as a code owner July 1, 2024 14:29
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.39%. Comparing base (2d08c7c) to head (2ae7942).

Files Patch % Lines
...te-resolver/src/integrations/sisyfos/connection.ts 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release51     #339      +/-   ##
=============================================
- Coverage      55.42%   55.39%   -0.03%     
=============================================
  Files            129      129              
  Lines          10054    10057       +3     
  Branches        2481     2417      -64     
=============================================
- Hits            5572     5571       -1     
- Misses          4105     4108       +3     
- Partials         377      378       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mint-dewit mint-dewit merged commit f6a3609 into release51 Jul 3, 2024
36 checks passed
@nytamin nytamin deleted the fix/sisyfos-fade-time-SOFIE-1218 branch November 28, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants