feat: refactor singular-live device SOFIE-2492 #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release51 #337 +/- ##
=============================================
+ Coverage 54.84% 55.42% +0.57%
=============================================
Files 129 129
Lines 10095 10054 -41
Branches 2484 2416 -68
=============================================
+ Hits 5537 5572 +35
- Misses 4176 4480 +304
+ Partials 382 2 -380 ☔ View full report in Codecov by Sentry. |
nytamin
approved these changes
Jun 27, 2024
| } | ||
| }) | ||
| if (oldSingularLiveState) { | ||
| _.each(oldSingularLiveState.compositions, (composition: SingularComposition, compositionName) => { |
There was a problem hiding this comment.
minor note: Perhaps we should refactor away the underscore dependencies as well?
There was a problem hiding this comment.
I almost did, but there is a _.isEqual somewhere here which I'm not aware of a direct replacement for, so didn't feel it worth changing these other references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a: Code improvement
New Behavior
Refactors the Telemetrics device to the new structure
Testing Instructions
Other Information
Status