Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor tricaster device SOFIE-2497 #336

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Julusian
Copy link
Member

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Code improvement

New Behavior

Testing Instructions

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian requested a review from a team as a code owner June 25, 2024 15:18
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 65.51724% with 10 lines in your changes missing coverage. Please review.

Project coverage is 55.55%. Comparing base (1d433f3) to head (4670ca0).

Files Patch % Lines
...state-resolver/src/integrations/tricaster/index.ts 65.21% 8 Missing ⚠️
...ges/timeline-state-resolver/src/service/devices.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           release51     #336   +/-   ##
==========================================
  Coverage      55.55%   55.55%           
==========================================
  Files            129      129           
  Lines          10135    10106   -29     
  Branches        2483     2492    +9     
==========================================
- Hits            5630     5614   -16     
+ Misses          4132     4118   -14     
- Partials         373      374    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian merged commit 4b4d2f6 into release51 Jun 26, 2024
36 checks passed
@Julusian Julusian deleted the feat/refactor-tricaster-device branch June 26, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants